Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intervalstore: fix uint64 overflow #1609

Merged
merged 2 commits into from
Apr 29, 2021
Merged

intervalstore: fix uint64 overflow #1609

merged 2 commits into from
Apr 29, 2021

Conversation

acud
Copy link
Member

@acud acud commented Apr 28, 2021

fixes a bug where value of math.MaxUint64 has not been handled correctly by the intervalstore. This value is used by puller, therefore a subsequent erasing of intervals is needed.

@acud acud added the bug Something isn't working label Apr 28, 2021
@acud acud force-pushed the puller-uint64-overflow branch from 0551efa to 891513e Compare April 28, 2021 12:08
@acud acud self-assigned this Apr 28, 2021
@acud acud force-pushed the puller-uint64-overflow branch from 891513e to da7de8f Compare April 28, 2021 12:15
@acud acud force-pushed the puller-uint64-overflow branch from da7de8f to 0eb06e9 Compare April 28, 2021 12:18
@acud acud added the ready for review The PR is ready to be reviewed label Apr 28, 2021
@acud acud requested review from janos and zelig April 29, 2021 06:44
@acud acud merged commit 631c8d8 into master Apr 29, 2021
@acud acud deleted the puller-uint64-overflow branch April 29, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants