-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go 1.16 #1657
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 5 files at r1.
Reviewable status: 4 of 5 files reviewed, 2 unresolved discussions (waiting on @esadakar and @vandot)
.dockerignore, line 5 at r1 (raw file):
.gitignore .github .githooks
not sure if this is needed
.github/workflows/release.yaml, line 17 at r1 (raw file):
uses: actions/setup-go@v2 with: go-version: 1.16.3
i think that specifying only 1.16
should pick up the latest patch version. can someone corroborate that? same for the build matrix in go.yaml
^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 5 files at r1, 4 of 4 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @acud, @esadakar, and @vandot)
.github/workflows/release.yaml, line 17 at r1 (raw file):
Previously, acud (acud) wrote…
i think that specifying only
1.16
should pick up the latest patch version. can someone corroborate that? same for the build matrix ingo.yaml
^^
I believe you are right, done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @vandot)
This change is