Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go 1.16 #1657

Merged
merged 1 commit into from
May 6, 2021
Merged

go 1.16 #1657

merged 1 commit into from
May 6, 2021

Conversation

istae
Copy link
Member

@istae istae commented May 5, 2021

This change is Reviewable

@istae istae added the ready for review The PR is ready to be reviewed label May 5, 2021
@istae istae requested review from acud, svetomir and vandot May 5, 2021 10:15
Copy link
Member

@acud acud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 5 files at r1.
Reviewable status: 4 of 5 files reviewed, 2 unresolved discussions (waiting on @esadakar and @vandot)


.dockerignore, line 5 at r1 (raw file):

.gitignore
.github
.githooks

not sure if this is needed


.github/workflows/release.yaml, line 17 at r1 (raw file):

        uses: actions/setup-go@v2
        with:
          go-version: 1.16.3

i think that specifying only 1.16 should pick up the latest patch version. can someone corroborate that? same for the build matrix in go.yaml ^^

Copy link
Member Author

@istae istae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 5 files at r1, 4 of 4 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @acud, @esadakar, and @vandot)


.github/workflows/release.yaml, line 17 at r1 (raw file):

Previously, acud (acud) wrote…

i think that specifying only 1.16 should pick up the latest patch version. can someone corroborate that? same for the build matrix in go.yaml ^^

I believe you are right, done.

@istae istae requested a review from acud May 5, 2021 13:16
Copy link
Member

@acud acud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @vandot)

@acud acud merged commit 17f7837 into master May 6, 2021
@acud acud deleted the go1.6.3 branch May 6, 2021 08:00
istae added a commit that referenced this pull request May 24, 2021
istae added a commit that referenced this pull request May 24, 2021
istae added a commit that referenced this pull request May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants