Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: conventional commits linting in ci flow #1684

Merged
merged 1 commit into from
May 12, 2021
Merged

ci: conventional commits linting in ci flow #1684

merged 1 commit into from
May 12, 2021

Conversation

@acud acud force-pushed the ci-ccc-lint branch 6 times, most recently from 5f27ab1 to 6881f08 Compare May 10, 2021 15:11
@acud acud self-assigned this May 10, 2021
@acud acud added the ready for review The PR is ready to be reviewed label May 10, 2021
@acud acud changed the title ci: conventional commits ci: conventional commits linting in ci flow May 10, 2021
Copy link
Contributor

@mrekucci mrekucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I'd maybe consider setting the line length to 72 instead of 100 everywhere.

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @acud)


commitlint.config.js, line 4 at r1 (raw file):

	parserPreset: 'conventional-changelog-conventionalcommits',
	rules: {
		'body-leading-blank': [1, 'always'],

body-leading-blank: I'd make it level 2.

Copy link
Contributor

@mrekucci mrekucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @acud)

@acud acud merged commit 0b0bb9e into master May 12, 2021
@acud acud deleted the ci-ccc-lint branch May 12, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants