feat: time based settlements #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralph-pichler
force-pushed
the
time_settle_sync
branch
2 times, most recently
from
a6a3748 to
8433d93
Compare
ralph-pichler
force-pushed
the
async_settlement
branch
2 times, most recently
from
d86278f to
324133d
Compare
ralph-pichler
force-pushed
the
time_settle_sync
branch
from
8433d93 to
7c9719d
Compare
ralph-pichler
force-pushed
the
time_settle_sync
branch
11 times, most recently
from
cd54501 to
e9e591b
Compare
ralph-pichler
force-pushed
the
time_settle_sync
branch
2 times, most recently
from
a101ae8 to
951b3a8
Compare
Eknir
reviewed
May 17, 2021
pkg/debugapi/router.go
Outdated
|
|
||
| router.Handle("/settlements/{peer}", jsonhttp.MethodHandler{ | ||
| "GET": http.HandlerFunc(s.peerSettlementsHandler), | ||
| router.Handle("/pseudosettlements", jsonhttp.MethodHandler{ |
There was a problem hiding this comment.
Let's give this variable (user-exposed) a more proper name. We can leave the internal names at pseudosettlements.
suggestion: timesettlements
Eknir
reviewed
May 17, 2021
Eknir
reviewed
May 17, 2021
Eknir
reviewed
May 17, 2021
Eknir
reviewed
May 17, 2021
metacertain
force-pushed
the
time_settle_sync
branch
from
9df590e to
12ba9ea
Compare
anatollupacescu
approved these changes
May 17, 2021
ralph-pichler
force-pushed
the
time_settle_sync
branch
from
12ba9ea to
ee8fff0
Compare
Eknir
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is