Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch swap endpoint to localhost #1731

Merged
merged 4 commits into from
May 18, 2021
Merged

switch swap endpoint to localhost #1731

merged 4 commits into from
May 18, 2021

Conversation

vandot
Copy link
Contributor

@vandot vandot commented May 17, 2021 •
edited by acud
Loading

This change is Reviewable

@vandot vandot marked this pull request as draft May 17, 2021 09:11
@vandot vandot linked an issue May 17, 2021 that may be closed by this pull request
Update All Package Managers Default to Local Geth Node #1723
Closed
@vandot vandot force-pushed the swap-default branch 3 times, most recently from c251d84 to 14df833 Compare May 17, 2021 10:37
@vandot vandot requested review from acud and ralph-pichler May 17, 2021 10:38
Eknir
Eknir reviewed May 17, 2021
View reviewed changes
.goreleaser.yml Outdated Show resolved Hide resolved
Eknir
Eknir reviewed May 17, 2021
View reviewed changes
packaging/deb/postinst Outdated Show resolved Hide resolved
Eknir
Eknir reviewed May 17, 2021
View reviewed changes
packaging/rpm/post Outdated Show resolved Hide resolved
@vandot
Copy link
Contributor Author

vandot commented May 18, 2021

@Eknir is it better now?

Eknir
Eknir reviewed May 18, 2021
View reviewed changes
.goreleaser.yml Outdated Show resolved Hide resolved
Eknir
Eknir reviewed May 18, 2021
View reviewed changes
.goreleaser.yml Outdated Show resolved Hide resolved
Eknir
Eknir reviewed May 18, 2021
View reviewed changes
packaging/deb/postinst Outdated Show resolved Hide resolved
Eknir
Eknir approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@Eknir Eknir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once my last comment (see Mattermost) is taken into account, you can merge it! Thanks :)

@Eknir
Copy link
Contributor

Eknir commented May 18, 2021

LGTM! Can you remove the draft status from this PR and/or merge?

@vandot vandot marked this pull request as ready for review May 18, 2021 14:36
@vandot vandot merged commit 9c09ea2 into master May 18, 2021
@vandot vandot deleted the swap-default branch May 18, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldeffenb ldeffenb ldeffenb left review comments

@Eknir Eknir Eknir approved these changes

@acud acud acud approved these changes

@ralph-pichler ralph-pichler Awaiting requested review from ralph-pichler

Assignees
No one assigned
Labels
pull-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update All Package Managers Default to Local Geth Node
4 participants
@vandot @Eknir @ldeffenb @acud