Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend information returned by GET /stamps #2051

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Conversation

mrekucci
Copy link
Contributor

@mrekucci mrekucci commented Jun 10, 2021

On top of the current information, the returned data are
extended by: label, depth, amount, bucketDepth,
blockNumber, and immutableFlag.

#1971


This change is Reviewable

Copy link
Member

@acud acud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Reviewed 13 of 13 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mrekucci)

@mrekucci mrekucci force-pushed the extend-get-stamps branch from 827f3ce to 9747127 Compare June 11, 2021 15:36
@mrekucci mrekucci marked this pull request as ready for review June 11, 2021 15:38
@mrekucci mrekucci added the ready for review The PR is ready to be reviewed label Jun 11, 2021
@mrekucci mrekucci force-pushed the extend-get-stamps branch 2 times, most recently from 95f0a2f to 6fe215c Compare June 11, 2021 15:55
@mrekucci
Copy link
Contributor Author

@agazso

@mrekucci mrekucci force-pushed the extend-get-stamps branch from 6fe215c to f83040b Compare June 11, 2021 16:45
Copy link
Member

@janos janos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@zelig zelig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 19 of 19 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aloknerurkar, @anatollupacescu, and @mrekucci)


openapi/SwarmCommon.yaml, line 322 at r2 (raw file):

        utilization:
          type: integer
        label:

bucketDepth and timestamp needed too, once indexed stamps PR merged

@mrekucci mrekucci force-pushed the extend-get-stamps branch 2 times, most recently from 67c939a to 303b9b7 Compare June 14, 2021 09:27
@mrekucci mrekucci requested a review from zelig June 14, 2021 11:08
@mrekucci mrekucci force-pushed the extend-get-stamps branch from 303b9b7 to dae9e17 Compare June 14, 2021 11:08
Copy link
Contributor Author

@mrekucci mrekucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 19 files reviewed, 1 unresolved discussion (waiting on @aloknerurkar, @anatollupacescu, and @zelig)


openapi/SwarmCommon.yaml, line 322 at r2 (raw file):

Previously, zelig (Viktor Trón) wrote…

bucketDepth and timestamp needed too, once indexed stamps PR merged

Done.

Copy link
Member

@zelig zelig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 19 of 19 files at r3.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @aloknerurkar, @anatollupacescu, @mrekucci, and @zelig)


pkg/api/postage.go, line 107 at r3 (raw file):

	Depth       uint8          `json:"depth"`
	Amount      *bigint.BigInt `json:"amount"`
	BucketDepth uint8          `json:"bucketDepth"`

immutable flag stsill missing

@mrekucci mrekucci force-pushed the extend-get-stamps branch from 29d9144 to 0a79ffd Compare June 15, 2021 06:19
@mrekucci mrekucci requested a review from zelig June 15, 2021 06:19
Copy link
Contributor Author

@mrekucci mrekucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @aloknerurkar, @anatollupacescu, and @zelig)


pkg/api/postage.go, line 107 at r3 (raw file):

Previously, zelig (Viktor Trón) wrote…

immutable flag stsill missing

Done.

@mrekucci mrekucci force-pushed the extend-get-stamps branch from 0a79ffd to b6c514b Compare June 15, 2021 06:22
@mrekucci mrekucci merged commit 5971555 into master Jun 15, 2021
@mrekucci mrekucci deleted the extend-get-stamps branch June 15, 2021 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants