-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extend information returned by GET /stamps #2051
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Reviewed 13 of 13 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @mrekucci)
827f3ce
to
9747127
Compare
95f0a2f
to
6fe215c
Compare
6fe215c
to
f83040b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 19 of 19 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aloknerurkar, @anatollupacescu, and @mrekucci)
openapi/SwarmCommon.yaml, line 322 at r2 (raw file):
utilization: type: integer label:
bucketDepth and timestamp needed too, once indexed stamps PR merged
67c939a
to
303b9b7
Compare
303b9b7
to
dae9e17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 19 files reviewed, 1 unresolved discussion (waiting on @aloknerurkar, @anatollupacescu, and @zelig)
openapi/SwarmCommon.yaml, line 322 at r2 (raw file):
Previously, zelig (Viktor Trón) wrote…
bucketDepth and timestamp needed too, once indexed stamps PR merged
Done.
39e1185
to
29d9144
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 19 of 19 files at r3.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @aloknerurkar, @anatollupacescu, @mrekucci, and @zelig)
pkg/api/postage.go, line 107 at r3 (raw file):
Depth uint8 `json:"depth"` Amount *bigint.BigInt `json:"amount"` BucketDepth uint8 `json:"bucketDepth"`
immutable flag stsill missing
29d9144
to
0a79ffd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @aloknerurkar, @anatollupacescu, and @zelig)
pkg/api/postage.go, line 107 at r3 (raw file):
Previously, zelig (Viktor Trón) wrote…
immutable flag stsill missing
Done.
0a79ffd
to
b6c514b
Compare
On top of the current information, the returned data are
extended by: label, depth, amount, bucketDepth,
blockNumber, and immutableFlag.
#1971
This change is