Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: early tx api #2210

Merged
merged 1 commit into from
Jun 24, 2021
Merged

feat: early tx api #2210

merged 1 commit into from
Jun 24, 2021

Conversation

ralph-pichler
Copy link
Member

@ralph-pichler ralph-pichler commented Jun 23, 2021

already enable /transactions endpoints on the early debug api so that it is available during chequebook deployment.


This change is Reviewable

@ralph-pichler ralph-pichler added the ready for review The PR is ready to be reviewed label Jun 23, 2021
@ralph-pichler ralph-pichler self-assigned this Jun 23, 2021
Copy link
Member

@acud acud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

return nil, fmt.Errorf("is synced: %w", err)
}
if !isSynced {
logger.Infof("waiting to sync with the Ethereum backend")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment on other PR about ethereum

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what other PR?

@ralph-pichler ralph-pichler merged commit 3d9bcfd into master Jun 24, 2021
@ralph-pichler ralph-pichler deleted the tx_api_enable branch June 24, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants