feat: announce to lightnodes #2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acud
added
ready for review
notanatol
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we announce nodes to light nodes only when they connect. This does not allow them to know about new nodes as they join the network. This also causes the integration tests to fail, as light nodes may connect early to the bootnode, never knowing anything about any other node in the network, leaving them only with a connection to the bootnode, which results in the tests to flake much more, since they overdraft with the bootnode very quickly, which then eventually results in errors in retrieval.
This PR rectifies this by notifying light nodes about new full nodes as they join the network.
This change is