fix: removed kademlia and libp2p discrepancy kludge

[istae]

After running a bee node in main-net for two days with the discrepancy metric, it was discovered that the issue has been fixed and the kludge can be removed.

PR includes deepsource fixes:
kad.connected renamed to kad.onConnected
pslice.exists renamed to pslice.index
Announce, Connected, AnnounceTo split into two new functions to avoid control coupling or simplified

This change is 

[acud]

should we PR this to master? maybe running a bunch of nodes in a custom testnet/mainnet cluster would do the trick, so we can PR and fix the bug in one go?

[mrekucci]

Reviewed 1 of 2 files at r1.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @istae)

---

pkg/topology/kademlia/metrics.go, line 137 at r1 (raw file):

			Namespace: m.Namespace,
			Subsystem: subsystem,
			Name:      "p2p_kademlia_discrepancy",

I'd remove the kademlia from the Name since it is already explicitly stated in the subsystem variable.

---

pkg/topology/kademlia/metrics.go, line 138 at r1 (raw file):

			Subsystem: subsystem,
			Name:      "p2p_kademlia_discrepancy",
			Help:      "Discrepancy counter between lists of peers in kademlia and libp2p",

I'd also remove the counter from the description, since it is implicit. Maybe The discrepancy between lists of peers in kademlia and libp2p.

[mrekucci]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @istae)

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
No Duplication information