Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pss target input validation #2463

Merged
merged 2 commits into from
Sep 2, 2021
Merged

feat: pss target input validation #2463

merged 2 commits into from
Sep 2, 2021

Conversation

AuHau
Copy link
Contributor

@AuHau AuHau commented Sep 1, 2021

This PR improves the API responses for not valid PSS targets and improves documentation of the PSS targets


This change is Reviewable

@acud
Copy link
Member

acud commented Sep 1, 2021

@AuHau tests are failing

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AuHau
Copy link
Contributor Author

AuHau commented Sep 2, 2021

Thanks, @acud for the info. It is fixed!

Copy link
Contributor

@mrekucci mrekucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AuHau)

@AuHau AuHau changed the title feat: pss input validation feat: pss target input validation Sep 2, 2021
@AuHau AuHau merged commit ef1c383 into master Sep 2, 2021
@AuHau AuHau deleted the feat/pss-validation branch September 2, 2021 09:46
@acud acud added this to the v1.2.0 milestone Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants