Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve metrics #2487

Merged
merged 1 commit into from
Sep 9, 2021
Merged

chore: improve metrics #2487

merged 1 commit into from
Sep 9, 2021

Conversation

acud
Copy link
Member

@acud acud commented Sep 8, 2021

This change is Reviewable

@acud acud self-assigned this Sep 8, 2021
@acud acud added the ready for review The PR is ready to be reviewed label Sep 8, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mrekucci mrekucci requested a review from janos September 9, 2021 08:20
Copy link
Contributor

@mrekucci mrekucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aloknerurkar and @janos)

@acud acud merged commit c958209 into master Sep 9, 2021
@acud acud deleted the metrics-improvements branch September 9, 2021 11:08
@acud acud added this to the v1.2.0 milestone Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants