Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ping time metric #2498

Merged
merged 5 commits into from
Sep 14, 2021
Merged

feat: ping time metric #2498

merged 5 commits into from
Sep 14, 2021

Conversation

istae
Copy link
Member

@istae istae commented Sep 14, 2021 •
edited
Loading

This should make network latency observable.

This change is Reviewable

@istae istae added the ready for review The PR is ready to be reviewed label Sep 14, 2021
acud
acud reviewed Sep 14, 2021
View reviewed changes
pkg/hive/hive.go Outdated Show resolved Hide resolved
@istae istae changed the title feat: ping metric feat: ping time metric Sep 14, 2021
acud
acud reviewed Sep 14, 2021
View reviewed changes
pkg/hive/metrics.go Outdated Show resolved Hide resolved
@istae istae requested a review from acud September 14, 2021 17:30
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@istae istae merged commit a4eb4dc into master Sep 14, 2021
@istae istae deleted the ping-metric branch September 14, 2021 20:35
@acud acud added this to the v1.2.0 milestone Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acud acud acud approved these changes

@aloknerurkar aloknerurkar aloknerurkar approved these changes

Assignees
No one assigned
Labels
pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@istae @aloknerurkar @acud