Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed neighborhood check for replication #2526

Merged
merged 4 commits into from
Sep 27, 2021

Conversation

istae
Copy link
Member

@istae istae commented Sep 20, 2021

This change is Reviewable

@istae istae force-pushed the neighborhood-check-remove branch from a3ba73f to a9b0aca Compare September 21, 2021 11:56
@istae istae force-pushed the neighborhood-check-remove branch from f237856 to ad4649b Compare September 21, 2021 13:51
@istae istae added the ready for review The PR is ready to be reviewed label Sep 21, 2021
pkg/pushsync/pushsync.go Show resolved Hide resolved
@istae istae requested a review from acud September 22, 2021 07:49
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@istae istae requested review from acud and notanatol September 27, 2021 10:56
Copy link
Contributor

@mrekucci mrekucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r3, 2 of 3 files at r4, 1 of 1 files at r6, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @notanatol)

@istae istae merged commit 2d68a79 into master Sep 27, 2021
@istae istae deleted the neighborhood-check-remove branch September 27, 2021 15:49
@acud acud added this to the v1.2.0 milestone Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants