feat: kademlia blocklists peer on ping timeout

[istae]

This change is 

[mrekucci]

Reviewed 1 of 4 files at r1, 1 of 1 files at r2.
Reviewable status: 1 of 4 files reviewed, all discussions resolved (waiting on @acud, @mrekucci, and @notanatol)

---

pkg/blocker/blockler.go, line 17 at r2 (raw file):

type peer struct {
	flagged    bool      // indicates whether the peer is actively flagged

You can get rid of the flagged field. Instead of this, you can use time zero value as a sentinel and as a result, the code will have more clarity.

---

pkg/blocker/blockler.go, line 65 at r2 (raw file):
As a first iteration this is good, just keep in mind that it can be quite memory intensive, see the documentation:

The underlying Timer is not recovered by the garbage collector
until the timer fires. If efficiency is a concern, use NewTimer
instead and call Timer.Stop if the timer is no longer needed.

---

pkg/p2p/p2p.go, line 38 at r2 (raw file):

type Blocklister interface {
	// Blocklist will disconnect a peer and put it on a blocklist (blocking in & out connections) for provided duration

Missing period at the end of the sentence. The duration on the line below should be capitalized.

[mrekucci]

Reviewed 1 of 3 files at r3, 4 of 4 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @acud)

---

pkg/blocker/blockler.go, line 22 at r5 (raw file):

var (
	wakeupTime time.Duration = time.Second * 10

This can be a constant.

[acud]

Reviewed 1 of 3 files at r3, 3 of 4 files at r5.
Reviewable status: 2 of 5 files reviewed, 1 unresolved discussion (waiting on @acud, @istae, and @mrekucci)

---

pkg/blocker/blockler.go, line 5 at r5 (raw file):

// license that can be found in the LICENSE file.

package blocker

file needs to be renamed

---

pkg/blocker/blockler.go, line 107 at r5 (raw file):

// must be called only once.
func (b *Blocker) Close() error {
	b.quit <- struct{}{}

it is better to close the channel since a naked write can block for a long time. also, since the worker goroutine might need to use the disconnecter interface even after the channel is closed, resulting in a panic (this is not the case right now, because the naked right makes sure that the synchronization happens in the correct way).

[notanatol]

Reviewable status: 2 of 5 files reviewed, 1 unresolved discussion (waiting on @acud, @istae, and @mrekucci)

---

pkg/blocker/blockler.go, line 22 at r5 (raw file):

Previously, mrekucci wrote…

This can be a constant.

it's being overwritten in the export_test.go for the purpose of testing.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication