feat!: only consider backbone nodes for core protocols

[istae]

fixes #2555
fixes #2550

This change is 

[acud]

Nice :) I have a few comments

[codecov-commenter]

Codecov Report

Merging #2565 (4e41e2f) into master (e53b36c) will increase coverage by 0.26%.
The diff coverage is 87.26%.

@@            Coverage Diff             @@
##           master    #2565      +/-   ##
==========================================
+ Coverage   63.54%   63.81%   +0.26%     
==========================================
  Files         232      235       +3     
  Lines       25937    26222     +285     
==========================================
+ Hits        16482    16733     +251     
- Misses       7958     7987      +29     
- Partials     1497     1502       +5     

Impacted Files	Coverage Δ
pkg/puller/puller.go	67.68% <ø> (ø)
pkg/pullsync/pullsync.go	48.33% <ø> (ø)
pkg/retrieval/retrieval.go	64.06% <ø> (-0.32%)	⬇️
pkg/p2p/libp2p/libp2p.go	61.60% <70.00%> (-0.03%)	⬇️
pkg/topology/kademlia/kademlia.go	75.54% <80.76%> (-0.54%)	⬇️
pkg/p2p/libp2p/internal/reacher/metrics.go	89.47% <89.47%> (ø)
pkg/p2p/libp2p/internal/reacher/reacher.go	92.15% <92.15%> (ø)
pkg/chainsyncer/chainsyncer.go	81.15% <100.00%> (+2.17%)	⬆️
pkg/p2p/p2p.go	100.00% <100.00%> (ø)
pkg/pushsync/pushsync.go	66.37% <100.00%> (+0.07%)	⬆️
... and 23 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e53b36c...4e41e2f. Read the comment docs.

[acud]

Reviewed 2 of 3 files at r1, 2 of 2 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @istae)

---

pkg/blocker/blocker.go, line 91 at r3 (raw file):

	defer b.mux.Unlock()

	_, ok := b.peers[addr.ByteString()]

if _,ok := b.peers[addr.ByteString()]; !ok { b.peers[addr] = &peer.....}

---

pkg/reacher/reacher.go, line 1 at r3 (raw file):

package reacher

copyright missing

[mrekucci]

Reviewed 1 of 2 files at r3, 2 of 3 files at r4, 2 of 4 files at r7, 1 of 1 files at r8, 1 of 1 files at r9, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @acud and @istae)

---

pkg/reacher/metrics.go, line 25 at r9 (raw file):

			Subsystem: subsystem,
			Name:      "pings",
			Help:      "Ping counter.",

I'd suggest using phrases as: "The number of pings made."

---

pkg/reacher/metrics.go, line 30 at r9 (raw file):

			Namespace: m.Namespace,
			Subsystem: subsystem,
			Name:      "ping_timer",

I'd suggest using ping_duration

---

pkg/reacher/metrics.go, line 31 at r9 (raw file):

			Subsystem: subsystem,
			Name:      "ping_timer",
			Help:      "Ping timer.",

I'd suggest using phrases as: "The duration of a ping".

[acud]

few comments:

• reacher package should be internal to libp2p package
• reacher.New should be called when SetPickyNotifier is called on libp2p with the kademlia instance (right now it is not wired at all)
• interface in the p2p package should include both notifiers:

type PickyNotifier interface {
	Picker
	Notifier
	ReachabilityUpdater
	ReachableNotifier
}

[mrekucci]

Reviewed 9 of 20 files at r15, 8 of 14 files at r16, 6 of 6 files at r17, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @acud and @istae)

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
0.0% Duplication

[ldeffenb]

@istae Just to be clear, since this PR has been merged into master, then master builds now contain the protocol version changes which makes it a breaking change and no longer compatible with the current testnet and mainnet swarms?