fix: never store max uint topmost #2566
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Looks like a good fix to me. Of course, it should only ever happen if someone (like me) does this experimental code in handling a pullsync request:
o = new(pb.Offer)
o.Topmost = rn.To
o.Hashes = make([]byte, 0)
s.metrics.OutboundOfferZeroCounter.Inc()
return o, nil, nil
without first checking that rn.To is not a "live" request which ends at math.MaxUint64 by design.
But then, I guess it could also happen a few decades (centuries?) from now when some swarm node has gone through math.MaxUint64 chunks in a single localstore pullsync bin.
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @acud)
This change is