Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pusher): non-fatal tag error #2569

Merged
merged 1 commit into from
Oct 5, 2021
Merged

fix(pusher): non-fatal tag error #2569

merged 1 commit into from
Oct 5, 2021

Conversation

acud
Copy link
Member

@acud acud commented Oct 5, 2021

fixes #2568

This change is Reviewable

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ldeffenb
Copy link
Collaborator

ldeffenb commented Oct 5, 2021

Wow, good catch on the other two! They'd be a lot harder to cause and/or notice than simply deleting the tag of a chunk that's still in the push queue.

@acud acud added the ready for review The PR is ready to be reviewed label Oct 5, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #2569 (1df9263) into master (853737d) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2569      +/-   ##
==========================================
- Coverage   63.79%   63.75%   -0.05%     
==========================================
  Files         232      232              
  Lines       25734    25751      +17     
==========================================
  Hits        16418    16418              
- Misses       7830     7847      +17     
  Partials     1486     1486              
Impacted Files Coverage Δ
pkg/pusher/pusher.go 69.70% <0.00%> (-2.09%) ⬇️
pkg/localstore/subscription_push.go 71.84% <0.00%> (-3.89%) ⬇️
pkg/puller/puller.go 67.68% <0.00%> (-0.70%) ⬇️
pkg/topology/kademlia/kademlia.go 76.02% <0.00%> (-0.58%) ⬇️
pkg/shed/schema.go 75.58% <0.00%> (ø)
pkg/puller/metrics.go 95.34% <0.00%> (+0.75%) ⬆️
pkg/localstore/subscription_pull.go 86.98% <0.00%> (+2.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 853737d...1df9263. Read the comment docs.

@mrekucci mrekucci requested a review from ldeffenb October 5, 2021 11:01
Copy link
Contributor

@mrekucci mrekucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ldeffenb)

Copy link
Collaborator

@ldeffenb ldeffenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to solve the issue (#2568) I found this morning.

@acud
Copy link
Member Author

acud commented Oct 5, 2021

Thanks for reporting @ldeffenb !

@acud acud merged commit e55462e into master Oct 5, 2021
@acud acud deleted the pusher-tag-err branch October 5, 2021 12:53
@acud acud added this to the v1.2.0 milestone Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pusher fails if tag is missing
5 participants