-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pusher): non-fatal tag error #2569
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Wow, good catch on the other two! They'd be a lot harder to cause and/or notice than simply deleting the tag of a chunk that's still in the push queue. |
Codecov Report
@@ Coverage Diff @@
## master #2569 +/- ##
==========================================
- Coverage 63.79% 63.75% -0.05%
==========================================
Files 232 232
Lines 25734 25751 +17
==========================================
Hits 16418 16418
- Misses 7830 7847 +17
Partials 1486 1486
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ldeffenb)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to solve the issue (#2568) I found this morning.
Thanks for reporting @ldeffenb ! |
fixes #2568
This change is