Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: blocker metrics #2576

Merged
merged 2 commits into from
Oct 7, 2021
Merged

chore: blocker metrics #2576

merged 2 commits into from
Oct 7, 2021

Conversation

istae
Copy link
Member

@istae istae commented Oct 6, 2021 •
edited by acud
Loading

This change is Reviewable

@istae istae added the ready for review The PR is ready to be reviewed label Oct 6, 2021
acud
acud suggested changes Oct 7, 2021
View reviewed changes
Copy link
Member

@acud acud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

registration of metrics through node.go is missing

mrekucci
mrekucci approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@mrekucci mrekucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the @acud comment, LGTM.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 7, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@istae istae requested a review from acud October 7, 2021 10:33
mrekucci
mrekucci approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@mrekucci mrekucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @acud)

@acud acud merged commit 29eb941 into master Oct 7, 2021
@acud acud deleted the blocker-metrics branch October 7, 2021 13:39
@acud acud added this to the v1.2.0 milestone Oct 8, 2021
aloknerurkar pushed a commit that referenced this pull request Oct 10, 2021
@istae @aloknerurkar
chore(blocker): add metrics (#2576)
1063446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acud acud acud approved these changes

@mrekucci mrekucci mrekucci approved these changes

Assignees
No one assigned
Labels
pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@istae @mrekucci @acud