Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show eth backend client on startup #2618

Merged
merged 2 commits into from
Nov 3, 2021
Merged

Conversation

ralph-pichler
Copy link
Member

@ralph-pichler ralph-pichler commented Oct 25, 2021

This change is Reviewable

@ralph-pichler ralph-pichler added the ready for review The PR is ready to be reviewed label Oct 25, 2021
@ralph-pichler ralph-pichler self-assigned this Oct 25, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2021

Codecov Report

Merging #2618 (b0a257e) into master (b1f1fe2) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2618      +/-   ##
==========================================
+ Coverage   63.39%   63.47%   +0.08%     
==========================================
  Files         232      232              
  Lines       25901    25901              
==========================================
+ Hits        16419    16440      +21     
+ Misses       7982     7964      -18     
+ Partials     1500     1497       -3     
Impacted Files Coverage Δ
pkg/localstore/mode_set.go 54.10% <0.00%> (-1.12%) ⬇️
pkg/shed/schema.go 75.58% <0.00%> (ø)
pkg/topology/kademlia/kademlia.go 75.00% <0.00%> (+0.28%) ⬆️
pkg/retrieval/retrieval.go 64.37% <0.00%> (+0.31%) ⬆️
pkg/p2p/libp2p/libp2p.go 61.09% <0.00%> (+0.93%) ⬆️
pkg/p2p/libp2p/peer.go 86.48% <0.00%> (+2.70%) ⬆️
pkg/localstore/subscription_push.go 81.55% <0.00%> (+5.82%) ⬆️
pkg/p2p/libp2p/stream.go 82.35% <0.00%> (+11.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1f1fe2...b0a257e. Read the comment docs.

@acud acud modified the milestones: v1.4.0, v1.5.0 Oct 25, 2021
@ralph-pichler ralph-pichler removed the ready for review The PR is ready to be reviewed label Oct 25, 2021
@ralph-pichler
Copy link
Member Author

ralph-pichler commented Oct 25, 2021

will require minor adjustments to the eth backend in ci environment to work properly done

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ralph-pichler ralph-pichler added the ready for review The PR is ready to be reviewed label Oct 29, 2021
@acud acud modified the milestones: v1.5.0, v1.4.0 Nov 1, 2021
@ralph-pichler ralph-pichler merged commit d421d93 into master Nov 3, 2021
@ralph-pichler ralph-pichler deleted the eth_client_info branch November 3, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants