New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(api): remove deprecated stamps endpoint #2632

Merged

acud merged 2 commits into master from remove-deprecated

Nov 4, 2021

Member

acud commented Nov 1, 2021 •

edited

Loading

endpoints were marked for deprecation in July this year, so they qualify for removal at this point.

This change is


          refactor(api): remove deprecated stamps endpoint

d820c31

bee-runner bot added the pull-request label

codecov-commenter commented Nov 1, 2021

Codecov Report

Merging #2632 (d820c31) into master (5a6c234) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2632      +/-   ##
==========================================
- Coverage   63.51%   63.42%   -0.09%     
==========================================
  Files         233      232       -1     
  Lines       25901    25776     -125     
==========================================
- Hits        16450    16348     -102     
+ Misses       7956     7936      -20     
+ Partials     1495     1492       -3

Impacted Files	Coverage Δ
pkg/api/router.go	`98.40% <ø> (-0.17%)`	⬇️
pkg/localstore/subscription_pull.go	`91.09% <0.00%> (+4.10%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a6c234...d820c31. Read the comment docs.

acud self-assigned this

acud added the ready for review label

notanatol approved these changes

View reviewed changes

acud added this to the v1.4.0 milestone

mrekucci suggested changes

View reviewed changes

Contributor

mrekucci left a comment

Should be also removed from the Open API spec.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @acud)


          chore(openapi): remove endpoints

da32d33

sonarqubecloud bot commented Nov 3, 2021

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

acud commented

View reviewed changes

Member Author

acud left a comment

Reviewable status: 4 of 5 files reviewed, all discussions resolved (waiting on @acud)

acud requested a review from mrekucci

November 3, 2021 17:40

mrekucci approved these changes

View reviewed changes

Contributor

mrekucci left a comment

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @acud)

acud merged commit f78ad3b into master

acud deleted the remove-deprecated branch

November 4, 2021 09:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pull-request ready for review