Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: continue on invalid stamp #2637

Merged
merged 1 commit into from
Nov 2, 2021
Merged

fix: continue on invalid stamp #2637

merged 1 commit into from
Nov 2, 2021

Conversation

mrekucci
Copy link
Contributor

@mrekucci mrekucci commented Nov 2, 2021

This change is Reviewable

@mrekucci mrekucci requested a review from acud November 2, 2021 09:56
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #2637 (8741a87) into master (5a6c234) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2637      +/-   ##
==========================================
- Coverage   63.51%   63.45%   -0.06%     
==========================================
  Files         233      233              
  Lines       25901    25902       +1     
==========================================
- Hits        16450    16437      -13     
- Misses       7956     7969      +13     
- Partials     1495     1496       +1     
Impacted Files Coverage Δ
pkg/pusher/pusher.go 75.15% <100.00%> (+0.15%) ⬆️
pkg/p2p/libp2p/stream.go 70.58% <0.00%> (-11.77%) ⬇️
pkg/localstore/subscription_push.go 73.68% <0.00%> (-5.27%) ⬇️
pkg/localstore/subscription_pull.go 84.24% <0.00%> (-2.74%) ⬇️
pkg/retrieval/retrieval.go 64.06% <0.00%> (-0.32%) ⬇️
pkg/topology/kademlia/kademlia.go 74.58% <0.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a6c234...8741a87. Read the comment docs.

@acud acud added this to the v1.4.0 milestone Nov 2, 2021
@mrekucci mrekucci merged commit ed39059 into master Nov 2, 2021
@mrekucci mrekucci deleted the fix-continue branch November 2, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants