Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(handshake)!: bump protocol version #2676

Merged
merged 1 commit into from
Nov 23, 2021
Merged

chore(handshake)!: bump protocol version #2676

merged 1 commit into from
Nov 23, 2021

Conversation

acud
Copy link
Member

@acud acud commented Nov 22, 2021

This change is Reviewable

@acud acud self-assigned this Nov 22, 2021
@acud acud added the ready for review The PR is ready to be reviewed label Nov 22, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@acud acud changed the title chore(handshake): bump protocol version chore(handshake)!: bump protocol version Nov 22, 2021
@acud acud added this to the v1.4.0 milestone Nov 22, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #2676 (8668706) into master (014b476) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2676      +/-   ##
==========================================
- Coverage   63.73%   63.60%   -0.13%     
==========================================
  Files         234      236       +2     
  Lines       26100    26561     +461     
==========================================
+ Hits        16634    16895     +261     
- Misses       7970     8151     +181     
- Partials     1496     1515      +19     
Impacted Files Coverage Δ
pkg/p2p/libp2p/internal/handshake/handshake.go 77.09% <ø> (ø)
pkg/api/api.go 66.36% <0.00%> (-8.75%) ⬇️
pkg/debugapi/router.go 97.27% <0.00%> (-2.73%) ⬇️
pkg/retrieval/retrieval.go 62.04% <0.00%> (-2.33%) ⬇️
pkg/accounting/accounting.go 58.95% <0.00%> (-0.51%) ⬇️
pkg/pushsync/pushsync.go 66.16% <0.00%> (-0.22%) ⬇️
cmd/bee/cmd/start.go 2.35% <0.00%> (-0.03%) ⬇️
pkg/debugapi/debugapi.go 100.00% <0.00%> (ø)
pkg/topology/kademlia/kademlia.go 75.54% <0.00%> (ø)
pkg/auth/auth.go 60.37% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 014b476...8668706. Read the comment docs.

@acud acud merged commit d12ae23 into master Nov 23, 2021
@acud acud deleted the 140-rc2 branch November 23, 2021 07:48
aloknerurkar pushed a commit that referenced this pull request Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants