Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore greylist for self verification #2688

Merged
merged 2 commits into from
Nov 29, 2021
Merged

Conversation

ralph-pichler
Copy link
Member

@ralph-pichler ralph-pichler commented Nov 26, 2021

Currently we greylist our own address if the node is started before the transaction has been included and one block on top (which can happen if you use a transaction from outside bee). Which means we cannot attempt to start the node for another 5 minutes. This adds an exception for this check.

This change is Reviewable

@ralph-pichler ralph-pichler self-assigned this Nov 26, 2021
@ralph-pichler ralph-pichler added the ready for review The PR is ready to be reviewed label Nov 26, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #2688 (3313d4c) into master (f50cc34) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2688      +/-   ##
==========================================
+ Coverage   63.53%   63.62%   +0.09%     
==========================================
  Files         236      236              
  Lines       26606    26606              
==========================================
+ Hits        16905    16929      +24     
+ Misses       8182     8161      -21     
+ Partials     1519     1516       -3     
Impacted Files Coverage Δ
pkg/p2p/libp2p/internal/handshake/handshake.go 77.09% <100.00%> (ø)
pkg/transaction/sender_matcher.go 65.48% <100.00%> (ø)
pkg/retrieval/retrieval.go 62.34% <0.00%> (+0.30%) ⬆️
pkg/localstore/mode_set.go 55.22% <0.00%> (+1.11%) ⬆️
pkg/localstore/mode_put.go 60.05% <0.00%> (+1.14%) ⬆️
pkg/p2p/libp2p/internal/reacher/reacher.go 92.20% <0.00%> (+1.29%) ⬆️
pkg/localstore/subscription_pull.go 86.98% <0.00%> (+2.73%) ⬆️
pkg/localstore/subscription_push.go 78.94% <0.00%> (+5.26%) ⬆️
pkg/p2p/libp2p/stream.go 82.35% <0.00%> (+11.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f50cc34...3313d4c. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@acud acud merged commit 07ef74c into master Nov 29, 2021
@acud acud deleted the ignore_greylist_for_self branch November 29, 2021 13:49
@acud acud added this to the v1.4.1 milestone Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants