feat: add basic metrics for sharky #2759
Conversation
mrekucci
force-pushed
the
sharky-metrics
branch
from
9200807 to
0583efe
Compare
pkg/sharky/store.go
Outdated
| } | ||
| return sh, nil | ||
| store.metrics.ShardSize.Set(float64(len(store.shards))) |
There was a problem hiding this comment.
just to mention, this is not shard size but number of shard. shard size would be the number of the items in the shard, which would be the filesize/datasize and should be updated when the shard grows
|
also missing - you need to register the metrics in the |
mrekucci
force-pushed
the
sharky-metrics
branch
from
0583efe to
b7cdf69
Compare
Yes, but that would be done in the #2682 PR, since the sharky is instantiated there. |
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @acud and @aloknerurkar)
pkg/sharky/store.go, line 68 at r1 (raw file):
Previously, mrekucci wrote…
Done.
this is simply shardCnt variable
aloknerurkar
force-pushed
the
sharky-pkg
branch
2 times, most recently
from
060da23 to
26f14b7
Compare
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @acud and @aloknerurkar)
pkg/sharky/store.go, line 68 at r1 (raw file):
Previously, zelig (Viktor Trón) wrote…
this is simply
shardCntvariable
Done.
mrekucci
force-pushed
the
sharky-metrics
branch
from
b7cdf69 to
d773c41
Compare
mrekucci
force-pushed
the
sharky-metrics
branch
from
d773c41 to
df5db56
Compare
Introduces basic metrics for sharky as read, write counters and their error counters, shard size counter.
This change is