refactor: allow duplicate handshakes #2794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrekucci
approved these changes
Feb 9, 2022
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @acud)
acud
force-pushed
the
remove-dupe-handshake
branch
from
0f6947a to
de176fe
Compare
aloknerurkar
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed while looking into various errors we've been running into on the libp2p abstraction level, it has been concluded that removing the duplicate handshake constraint is not beneficial and should be removed. It does not guard against anything, and duplicate handshakes are allowed even with this code section (since we can dial to a node and a node can dial back and there's no keeping track of the bidirectional connections). Furthermore, libp2p allows for multiple underlying connections and will use the best one when sending a message according to its internal heuristics of connection selection.
This change is