Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: security role inheritance #2808

Merged
merged 2 commits into from
Feb 15, 2022
Merged

feat: security role inheritance #2808

merged 2 commits into from
Feb 15, 2022

Conversation

notanatol
Copy link
Contributor

@notanatol notanatol commented Feb 9, 2022

Checklist

  • I have read the coding guide
  • Code the inheritance tree
  • My change requires a documentation update and I have done it

Description

Hard coded list of roles with the inheritance relationship between them

Motivation and context (Optional)

We need an expressive way of defining permission inheritance.


This change is Reviewable

@notanatol notanatol added the in progress ongoing development , hold out with review label Feb 9, 2022
@notanatol notanatol changed the title feat: role inheritance feat: security role inheritance Feb 9, 2022
@notanatol
Copy link
Contributor Author

@AuHau @nugaon @agazso Feel free to drop the desired mapping of roles here in the comments and I'll code it.

@AuHau
Copy link
Contributor

AuHau commented Feb 12, 2022

Sorry for not getting back earlier to you about this!

I envision it in this order:
consumer > creator > accountant > maintainer

Where the "right-sided" role has all the "left-sided" role's permissions, if you know what I mean.

@notanatol
Copy link
Contributor Author

Sorry for not getting back earlier to you about this!

I envision it in this order: consumer > creator > accountant > maintainer

Where the "right-sided" role has all the "left-sided" role's permissions, if you know what I mean.

no worries, it's not blocking nor urgent.

I will code this hierarchy but I just want to mention that we have the freedom to also add new roles, we are not limited to this four.

@notanatol notanatol added ready for review The PR is ready to be reviewed and removed in progress ongoing development , hold out with review labels Feb 13, 2022
@notanatol notanatol merged commit 0b77fa6 into master Feb 15, 2022
@notanatol notanatol deleted the role-inheritance branch February 15, 2022 12:18
@aloknerurkar aloknerurkar added this to the 1.5.0 milestone Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants