fix: runtime panic #2836
Merged
fix: runtime panic #2836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aloknerurkar
reviewed
Mar 5, 2022
pkg/debugapi/debugapi.go
Outdated
| @@ -125,6 +126,9 @@ func (s *Service) Configure(overlay swarm.Address, p2p p2p.DebugService, pingpon | |||
| s.chequebook = chequebook | |||
| s.swapEnabled = swapEnabled | |||
| s.swap = swap | |||
| if !chainEnabled { | |||
There was a problem hiding this comment.
This extra parameter can be avoided by either initialising swap to noOpSwap before passing here or maybe checking if the swap == nil.
pkg/debugapi/debugapi.go
Outdated
| @@ -145,3 +149,54 @@ func (s *Service) ServeHTTP(w http.ResponseWriter, r *http.Request) { | |||
|
|
|||
| h.ServeHTTP(w, r) | |||
| } | |||
|
|
|||
| type noOpSwap struct { | |||
There was a problem hiding this comment.
So I went through the APIs to see how they are handled. Seems like there are a few errors like ErrNoChequebook which are being handled. I wonder if we should retain the errors here instead of returning empty responses? If API expects to send No Chequebook error if there is no chequebook, then this would sort of break that no?
acud
approved these changes
Mar 6, 2022
aloknerurkar
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Fixes the
/chequebookruntime panic.This change is