Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump btcd to version v2 #4516

Merged
merged 1 commit into from
Dec 19, 2023
Merged

chore: bump btcd to version v2 #4516

merged 1 commit into from
Dec 19, 2023

Conversation

mrekucci
Copy link
Contributor

@mrekucci mrekucci commented Dec 18, 2023

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

This PR bumps the btcd version that fixes the "btcd mishandles witness size checking" vulnerability: https://github.com/ethersphere/bee/security/dependabot/21

@mrekucci mrekucci force-pushed the deps branch 2 times, most recently from e5ddf58 to 60b09a5 Compare December 18, 2023 13:50
@mrekucci mrekucci changed the title chore: bump btcd to version v0.23.3 chore: bump btcd to version v0.23.4 Dec 18, 2023
@mrekucci mrekucci force-pushed the deps branch 3 times, most recently from 53fbbfc to bc18baa Compare December 18, 2023 14:52
@mrekucci mrekucci changed the title chore: bump btcd to version v0.23.4 chore: bump btcd to version v2 Dec 18, 2023
@mrekucci mrekucci merged commit 6adda08 into master Dec 19, 2023
12 checks passed
@mrekucci mrekucci deleted the deps branch December 19, 2023 08:50
@mrekucci mrekucci mentioned this pull request Dec 21, 2023
4 tasks
@janos
Copy link
Member

janos commented Feb 6, 2024

An addition external test cases were added to validate the compatibility of the changes in this PR https://github.com/janos/beetcec/blob/main/beetcec_test.go with tests passing https://github.com/janos/beetcec/actions/runs/7799842142/job/21271459563#step:8:67.

Please, review the tests in https://github.com/janos/beetcec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants