Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proof data race #4665

Merged
merged 5 commits into from
May 9, 2024
Merged

fix: proof data race #4665

merged 5 commits into from
May 9, 2024

Conversation

nugaon
Copy link
Member

@nugaon nugaon commented May 8, 2024

Data race appeared by referencing some elements of the buffer of the bmt pool in the bmt.Prover.Proof method.

it may resolve inclusion proof related errors as well in the redistribution game.

Other corrections have been made in TestMakeInclusionProofsRegression which is not flaky anymore.

fixes: #4531

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):

pkg/storer/sample.go Outdated Show resolved Hide resolved
@istae istae merged commit 1c71a72 into master May 9, 2024
12 of 14 checks passed
@istae istae deleted the fix/proof-data-race branch May 9, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage incentives pkg inclusion proof test flaking
2 participants