Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve create batch error response #4729

Merged
merged 5 commits into from
Jul 31, 2024

Conversation

acha-bill
Copy link
Contributor

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

Validate the minimum validity and return an appropriate error message.

Related Issue (Optional)

closes #4724

@acha-bill acha-bill force-pushed the feat-improve-create-batch-response branch from 3243ebf to ca5b0cb Compare July 19, 2024 04:38
@acha-bill acha-bill requested review from martinconic and istae July 19, 2024 09:35
@acha-bill acha-bill requested a review from istae July 27, 2024 12:45
@acha-bill acha-bill requested a review from janos July 30, 2024 23:16
@acha-bill acha-bill merged commit c518552 into master Jul 31, 2024
14 checks passed
@acha-bill acha-bill deleted the feat-improve-create-batch-response branch July 31, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

give more info to the user when a batch purchase fails due to low amount
4 participants