feat(pullsync): rate limit handler #4799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istae
force-pushed
the
pullsync-limiter
branch
from
dea93ba to
fc77ea9
Compare
ldeffenb
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Hard to tell if handler() has actually changed since it was relocated in the file, but aside from that and my two comments, I have no issues with this. Looking forward to seeing if it actually works!
It'd be nice to see metrics on how many delays actually occur, and/or how long the delay might be, but given the package layering, I don't see a reasonable way to do this.
istae
force-pushed
the
pullsync-limiter
branch
from
bdcae62 to
8ef3395
Compare
istae
force-pushed
the
pullsync-limiter
branch
from
6098a46 to
fdf635a
Compare
acha-bill
approved these changes
Sep 9, 2024
martinconic
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Added a basic rate limiter to pullsync handler.
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):