perf: remove unncessary goroutine pileup of skippeer workers #4993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinconic
reviewed
Feb 6, 2025
martinconic
reviewed
Feb 6, 2025
|
|
||
| defer l.wg.Done() | ||
|
|
||
| ticker := time.NewTicker(time.Minute) | ||
| ticker := time.NewTicker(d) |
There was a problem hiding this comment.
Should we have a fallback check before just in case we send d=0 , or smaller?
There was a problem hiding this comment.
The check in the constructor should be enough
gacevicljubisa
approved these changes
Feb 6, 2025
acha-bill
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Before, for each pushsync and retrieval, a separate skippeers list was created, along side it a worker that would prune entries based on a timer. Now, the worker is created once only for the errSkip peers list, and not for each request.
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):