Merge pull request #5 from sdboyer/iotas

Idiomatic go: use iotas for const declarations
ethersphere · Feb 19, 2014 · 531b3a9 · 531b3a9
2 parents 3dae732 + 357b4bc
commit 531b3a9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/ethwire/messaging.go b/ethwire/messaging.go
@@ -19,6 +19,9 @@ var MagicToken = []byte{34, 64, 8, 145}
 type MsgType byte
 
 const (
+ // Values are given explicitly instead of by iota because these values are
+ // defined by the wire protocol spec; it is easier for humans to ensure
+ // correctness when values are explicit.
  MsgHandshakeTy = 0x00
  MsgDiscTy = 0x01
  MsgPingTy = 0x02

diff --git a/peer.go b/peer.go
@@ -23,6 +23,9 @@ const (
 type DiscReason byte
 
 const (
+ // Values are given explicitly instead of by iota because these values are
+ // defined by the wire protocol spec; it is easier for humans to ensure
+ // correctness when values are explicit.
  DiscReRequested = 0x00
  DiscReTcpSysErr = 0x01
  DiscBadProto = 0x02
@@ -56,9 +59,9 @@ func (d DiscReason) String() string {
 type Caps byte
 
 const (
- CapPeerDiscTy = 0x01
- CapTxTy = 0x02
- CapChainTy = 0x04
+ CapPeerDiscTy = 1 << iota
+ CapTxTy
+ CapChainTy
 
  CapDefault = CapChainTy | CapTxTy | CapPeerDiscTy
 )