swarm/network: remove spammy log line #1011
Conversation
nonsense
requested review from
holisticode,
janos,
acud and
zelig
as code owners
| @@ -255,7 +255,7 @@ func (d *Delivery) RequestFromPeers(ctx context.Context, req *network.Request) ( | |||
| } | |||
| sp = d.getPeer(id) | |||
| if sp == nil { | |||
| log.Warn("Delivery.RequestFromPeers: peer not found", "id", id) | |||
| //log.Warn("Delivery.RequestFromPeers: peer not found", "id", id) | |||
There was a problem hiding this comment.
lets leave this. this warning occurring too many times is indicating a bug.
There was a problem hiding this comment.
I understand that this is a bug, but this is a very spammy log line, and it is not helpful.
400k times for a single peer. Users are complaining that this is filling their disks with logs, and rightly so.
I am currently looking into it, but we should not have another release with this spammy log.
The peer in question in the logs is actually present in the peer list, so I am not sure why d.getPeer(id) is returning nil.
There was a problem hiding this comment.
If it's a bug and we just silently "ignore" it, then we should open an issue to investigate it and find a solution.
| @@ -255,7 +255,7 @@ func (d *Delivery) RequestFromPeers(ctx context.Context, req *network.Request) ( | |||
| } | |||
| sp = d.getPeer(id) | |||
| if sp == nil { | |||
| log.Warn("Delivery.RequestFromPeers: peer not found", "id", id) | |||
| //log.Warn("Delivery.RequestFromPeers: peer not found", "id", id) | |||
There was a problem hiding this comment.
If it's a bug and we just silently "ignore" it, then we should open an issue to investigate it and find a solution.
|
@holisticode here is the issue. #999 |
nonsense
changed the title
|
@nonsense please use status labels |
|
I am not sure what status label you are talking about? This PR has been open for days with responses to your comments, and because of this there was no action on it. Also you had |
|
Closing this as we are piggy-backing it to another PR. |
No description provided.