This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
p2p/simulation: move connection methods from swarm/network/simulation #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactor was done as the second part of our current network testing efforts; as outlined in #1038. Co-authored-by: Elad Nachmias <theman@elad.im>
janos
approved these changes
Dec 13, 2018
acud
reviewed
Dec 13, 2018
As they are only used in the same package.
added 3 commits
December 14, 2018 14:18
Functions on Network struct return *Node and not enode.ID in general. Let's keep the interface consistent.
nolash
approved these changes
Dec 16, 2018
|
as merged upstream |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor was done as the second part of our current network
testing efforts; as outlined in #1038.
Co-authored-by: Elad Nachmias theman@elad.im
This PR is part two of four PRs that adds test and benchmark to ensure that the snapshot connection content is correct upon creation, and that the correct connections are made after snapshot is loaded. All actual connections should be contained in snapshot, and all connections and only those connections should be in the network after load.
Part one creates the correctness test and adds a vanilla benchmark function.
Part two will move connection methods from
swarm/network/simulationtop2p/simulationsPart three will add a snapshot generation binary leveraging the different configurations provided by part two.
Part four will add exhaustive benchmarks with different snapshots generated from part three.