storage: fix pyramid chunker and hasherstore possible deadlocks #1679
Conversation
| h.waitC <- ctx.Err() | ||
| select { | ||
| case h.waitC <- ctx.Err(): | ||
| case <-h.quitC: |
There was a problem hiding this comment.
check L142 above in func (h *hasherStore) Wait(ctx context.Context) error
There was a problem hiding this comment.
Still not so clear, but I guess the comment by the member in the owning object suggests that this is a channel for orderly shutdown.
The description of the PR suggests a fix on a deadlock. But the code seems rather to protect against closing the quitC when it's already closed, which is a panic not a deadlock? This is why I was curious
There was a problem hiding this comment.
Very well observed @nolash. Yes, this PR addresses a deadlock and a panic on closing a closed channel, problems that were found while running smoke tests on new syncer, but the fixes may be applied to the master.
There was a problem hiding this comment.
to second @janos, indeed the problem of close of closed channel is resolved by the Once. the change to this specific select structure is made to eliminate trivial writes to channel that are potential deadlocks
* 'master' of github.com:ethersphere/swarm: chunk, storage: chunk.Store multiple chunk Put (ethersphere#1681) storage: fix pyramid chunker and hasherstore possible deadlocks (ethersphere#1679) pss: Use distance to determine single guaranteed recipient (ethersphere#1672) storage: fix possible hasherstore deadlock on waitC channel (ethersphere#1674) network: Add adaptive capabilities message (ethersphere#1619) p2p/protocols, p2p/testing; conditional propagation of context (ethersphere#1648) api/http: remove unnecessary conversion (ethersphere#1673) storage: fix LazyChunkReader.join potential deadlock (ethersphere#1670) HTTP API support for pinning contents (ethersphere#1658) pot: Add Distance methods with tests (ethersphere#1621) README.md: Update Vendored Dependencies section (ethersphere#1667) network, p2p, vendor: move vendored p2p/testing under swarm (ethersphere#1647) build, vendor: use go modules for vendoring (ethersphere#1532)
This PR fixes possible deadlocks created in pyramid chunker and hasherstore.