This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
pushsync: optimize TestPushsyncSimulation #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonsense
reviewed
Sep 26, 2019
| @@ -52,7 +53,7 @@ var ( | |||
|
|
|||
| var ( | |||
| nodeCntFlag = flag.Int("nodes", 4, "number of nodes in simulation") | |||
| chunkCntFlag = flag.Int("chunks", 4, "number of chunks per upload in simulation") | |||
| chunkCntFlag = flag.Int("chunks", 1000, "number of chunks per upload in simulation") | |||
| testCasesFlag = flag.Int("cases", 4, "number of concurrent upload-download cases to test in simulation") | |||
There was a problem hiding this comment.
4 * 32 concurrent gets seems to be too many for Travis.
nonsense
reviewed
Sep 26, 2019
| g.Go(func() error { | ||
| defer func() { <-sem }() | ||
| _, err := store.Get(ctx, chunk.ModeGetRequest, storage.NewRequest(addr)) |
There was a problem hiding this comment.
Context is used incorrectly here - it has no timeout, which means that we have no global timeout for any retrieve requests.
I am not sure if Netstore.Get has the best interface, but it assumes that you set some timeout for the context.
There was a problem hiding this comment.
Not related to this PR, just making a mental node, maybe we want to change this in the future.
nonsense
approved these changes
Sep 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues when running TestPushsyncSimulation with larger number of chunks.
The main problem was in the download function trying to get all the chunks at once.
It was noticed in profiling that storage.GenerateRandomChunk took a noticeable time to acquire a mutex lock. It is replaced by a faster variant which does not generate a valid chunk, but a chunk that is good enough for the simulation.