Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

swap: fixed bug which needs cheques to be confirmed #1937

Merged
merged 3 commits into from
Nov 11, 2019
Merged

swap: fixed bug which needs cheques to be confirmed #1937

merged 3 commits into from
Nov 11, 2019

Conversation

holisticode
Copy link
Contributor

This PR fixes a bug in simulation tests for swap, where sometimes, due to timing issues, the test may hang because a new cheque arrives and the old one is not confirmed yet.

Fixes #1933

@holisticode holisticode self-assigned this Nov 8, 2019
@mortelli mortelli mentioned this pull request Nov 8, 2019
Closed
ralph-pichler
ralph-pichler approved these changes Nov 8, 2019
View reviewed changes
Copy link
Member

@ralph-pichler ralph-pichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still other issues happening in the tests sometimes but they seem to be unrelated to the changes in this PR. The pending cheque bug appears to be fixed.

janos
janos suggested changes Nov 11, 2019
View reviewed changes
Copy link
Member

@janos janos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for solving the issue. I can confirm that it is fixed by running test in the environment where failures happened frequently.

I have some comments related to data races, which should be easy to fix.

swap/simulations_test.go Show resolved Hide resolved
swap/simulations_test.go Show resolved Hide resolved
@holisticode
Copy link
Contributor Author

Thanks @janos for catching those races. I made fixes.

janos
janos approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@janos janos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@holisticode holisticode merged commit 2312b32 into master Nov 11, 2019
@mortelli mortelli deleted the incentives-pending-cheques branch November 11, 2019 20:57
@acud acud added this to the 0.5.3 milestone Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ralph-pichler ralph-pichler ralph-pichler approved these changes

@janos janos janos approved these changes

@santicomp2014 santicomp2014 Awaiting requested review from santicomp2014

@mortelli mortelli Awaiting requested review from mortelli

Assignees

@holisticode holisticode

Labels
incentives test
Projects
None yet
Milestone
0.5.3
Development

Successfully merging this pull request may close these issues.

Update swap simulation tests for pending cheques
4 participants
@holisticode @janos @ralph-pichler @acud