Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

[WIP] all: Update go-ethereum dependency to 1.9.7 #1938

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

chadsr
Copy link

@chadsr chadsr commented Nov 8, 2019

This PR bumps the go-ethereum dependency to v1.9.7, the latest release.

Changes are the result of these steps:

  • Bumped go.mod go-ethereum to v1.9.7
  • go mod verify
  • go mod tidy
  • go mod vendor
  • make vendor

My main motivation for this PR is that with go-ethereum 1.9.7, I can resolve #1799.
If any steps are not preferred ways to maintain modules here (like tidying), please let me know.

@chadsr chadsr changed the title all: Update go-ethereum dependency to 1.9.7 [WIP] all: Update go-ethereum dependency to 1.9.7 Nov 8, 2019
Copy link
Member

@janos janos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the upgrade and detailed steps that were done. We have a slightly different way to vendor libraries in order to copy forked c libraries from dependant packages. They are showing as deleted in this pr. There is a Makefile rule vendor that takes care of these cases. It should be enough just to call make vendor and commit changes.

@chadsr chadsr force-pushed the update-geth-1.9.7 branch 2 times, most recently from 5f6d3f2 to ba11dca Compare November 13, 2019 09:03
@chadsr
Copy link
Author

chadsr commented Nov 13, 2019

Hm, something seems to be broken/flakey with karalabe/usb/libusb still.

I've updated leveldb and also karalable/usb, which resolved some issues, but i'm still getting:
ERROR[11-13|10:11:56.147] Failed to enumerate USB devices hub=trezor vendor=21324 failcount=1 err="failed to initialize libusb: libusb: unknown error [code -99]"

Will do some more investigating to see what went wrong.

@acud acud added the cleanup code completion, add comments and more label Nov 15, 2019
@acud acud self-requested a review November 15, 2019 12:28
@chadsr chadsr force-pushed the update-geth-1.9.7 branch 2 times, most recently from a0b33b0 to 36ccdf4 Compare February 4, 2020 18:37
@chadsr
Copy link
Author

chadsr commented Feb 5, 2020

My priorities had been rearranged somewhat, but now i'm back to looking at this.

I'm finding it hard to track down the cause of the remaining failing test. It appears to be this regex check failing to match on the stdout output. I assume it expects a hash, but the value is in fact null.

Input is welcome from someone with a more complete overview of the swarm codebase :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cleanup code completion, add comments and more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants