Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

network: increase fetcher timeout #1979

Merged
merged 1 commit into from
Nov 26, 2019
Merged

network: increase fetcher timeout #1979

merged 1 commit into from
Nov 26, 2019

Conversation

acud
Copy link
Member

@acud acud commented Nov 25, 2019

Due to fetcher timeouts visible on grafana dashboards in smoke tests, and also due to reported timeouts on retrievals from end users, the fetcher search timeout is hereby increased.

Also piggybacking the change of stream timeouts to get their timeouts from timeouts package

@acud acud added the stability label Nov 25, 2019
@acud acud added this to the 0.5.3 milestone Nov 25, 2019
@acud acud self-assigned this Nov 25, 2019
Copy link
Contributor

@holisticode holisticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still feels quite arbitrary these timeouts...
Has there been any attempt at some point to literally play around intensively with different values by parametrizing them and observe results?

@acud
Copy link
Member Author

acud commented Nov 26, 2019

@holisticode @janos did and came to these numbers to improve user experience. we live, learn and slowly improve. we'll tweak them in due time

@acud acud merged commit 9804442 into master Nov 26, 2019
@acud acud deleted the fetcher-timeout branch November 26, 2019 05:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants