Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

network, storage: fix usage of base logger #2072

Merged
merged 1 commit into from
Jan 10, 2020
Merged

network, storage: fix usage of base logger #2072

merged 1 commit into from
Jan 10, 2020

Conversation

acud
Copy link
Member

@acud acud commented Jan 9, 2020

base logger was invoked with base string, but base string was already hardcoded in the base address logger constructor, resulting in errors while logger due to even number of parameters, and broken formatting of the addresses

@acud acud added the bug label Jan 9, 2020
@acud acud requested review from janos and pradovic January 9, 2020 04:09
@acud acud self-assigned this Jan 9, 2020
@acud acud added this to the 0.5.5 milestone Jan 9, 2020
pradovic
pradovic approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@pradovic pradovic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks! My bad, I thought I covered all those cases 🙈

@acud acud requested a review from nolash January 9, 2020 10:53
@acud acud merged commit de17e40 into master Jan 10, 2020
@acud acud deleted the fix-base-logger branch January 10, 2020 04:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradovic pradovic pradovic approved these changes

@janos janos janos approved these changes

@nolash nolash Awaiting requested review from nolash

Assignees

@acud acud

Labels
bug
Projects
None yet
Milestone
0.5.5
Development

Successfully merging this pull request may close these issues.
3 participants
@acud @janos @pradovic