This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
stream: remove semaphor hack #2096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f114078.
acud
force-pushed
the
stream-rm-sem-hack
branch
from
b2004db
to
7fa2005
Compare
pradovic
approved these changes
Feb 7, 2020
janos
approved these changes
Feb 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to revert this change since it has caused a significant instability in tests (many tests are flaking because of this change). I am not sure if we actually get this change to negatively affect syncing on production environment, but to be on the conservative side I'd prefer this to be removed.