This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
bmt, file: Extract AsyncHasher to separate package #2097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janos
reviewed
Feb 10, 2020
| @@ -0,0 +1,13 @@ | |||
| package testutil | |||
There was a problem hiding this comment.
Add copyright header to all new files.
file/hasher/hasher_test.go
Outdated
| t.ReportAllocs() | ||
| t.ResetTimer() | ||
| for i := 0; i < t.N; i++ { | ||
| asyncHash(bmtobj, 0, n, wh, idxs, segments) |
There was a problem hiding this comment.
Could this benchmark be unexpectedly optimised by compiler as the function result is not used anywhere?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a series of PRs that introduces an interface that allows chaining of components that receive a data stream and generate hashes and intermediate Merkle-Tree chunks. The individual PR steps will be partitioned from #2022 (branch https://github.com/nolash/swarm/tree/filehasher-avenged ) as follows:
IntroduceSectionWriter, implement this interface inbmt, makeAsyncHasherstandaloneAsyncHashertofile/hasher(this PR)SectionWritersub-component for hashing intermediate Merkle Tree levels.SectionWritercomponent executing the FileHasher algorithmio.ReaderandSectionWriter, and an implementation ofSectionWritercomponent that providesChunkoutput.SectionWriterthat provides encryption, along with a test utilitySectionWriterimplentation of a data cache.bmt.Hasherexports wtrAsyncHasherThis PR does not alter any logic. It merely moves the
AsyncHasherobject to thefile/hasherpackage, while exporting a few consts and vars inbmt/testutilthat are used across the sync and async tests.