chunk, prod, pss, storage, swarm: trigger trojan chunk sending #2166

santicomp2014 · 2020-04-24T13:20:29Z

EXPERIMENTAL
(will not merge to master)

WIP for triggering trojan chunk sending used by implementation for global pinning.

this is invoked after trying to download content and failing, this will be a trigger to start the global pinning lifecycle.

Related issue: #2161

This PR:

creates a new prod (recovery package) package for global pinning
implements a way to trigger the sending of the trojan chunk; this should happen after failing to download content which the node understands is globally pinned.
implemented by a fallback recoveryHook in netstore (similar to deliveryHook)
should use feed-base retrieval but this maybe branch off into a separate PR.
- sending should be done first with the hooks with a const target list hardwired in recovery package first
then it could be replaced with feed-based implementation

Remove TODOs for deprecated code after iteration

zelig · 2020-04-29T21:24:32Z

storage/netstore.go

@@ -99,6 +100,7 @@ type NetStore struct {
 	requestGroup singleflight.Group
 	RemoteGet    RemoteGetFunc
 	logger       log.Logger
+	prod         *prod.Prod


No, the dependency is the other way round more natural.
Here i would assign a function or if you insist, an interface with
Recover method

this was changed to be similar to Deliver hook.
This was one of the reasons there was an import cycle error.

…llback in netstore, will need iteration

zelig

i think this is done no?

mortelli

very nice job on the TestSenderCall func 👏

i think this needs just one more iteration and we're good to go 👍

prod/prod.go

prod/prod_test.go

…n prod tests, refactored methods common methods in pss/prod testing, added comments for deliver and recover callbacks in respective fields

santicomp2014

I addressed all the comments.
Thanks for the feedback

prod/prod.go

prod/prod_test.go

storage/netstore.go

prod/prod_test.go

mortelli

good stuff! thank you for addressing everything.

prod: added prod package

c2e8154

santicomp2014 added global pinning experimental implementation of global pinning builds on open PR Builds on a PR that is not yet merged. It is blocked until then and the diff won't make sense yet. in progress labels Apr 24, 2020

mortelli mentioned this pull request Apr 24, 2020

global pinning: phase 2 #2161

Closed

6 tasks

santicomp2014 added 3 commits April 27, 2020 10:29

Merge branch 'global-pinning' into global-pinning-trigger-trojanchunk

e6e20d3

prod: first iteration of testcase and prod methods

2d7dfd1

prod: first iteration of hooks

373f64d

mortelli removed the builds on open PR Builds on a PR that is not yet merged. It is blocked until then and the diff won't make sense yet. label Apr 27, 2020

mortelli assigned santicomp2014 Apr 27, 2020

santicomp2014 added 4 commits April 28, 2020 12:22

prod: TestRecoveryHook updated

1bfb068

prod,storage: removed multi hooks, only one

841224b

swarm, storage: added contact points for prod integration

7ae4045

swarm, storage: added hook for recover,first iteration

eb7d908

mortelli mentioned this pull request Apr 29, 2020

chunk, localstore, trojan, swarm: repair globally pinned content #2165

Merged

1 task

santicomp2014 added 4 commits April 29, 2020 09:01

prod: removed unnecessary comment

bf0a4d4

prod, storage, swarm: refactor into hook without struct in prod

e6a7e1a

storage: removed prod dependency

0333dd6

prod: added comment, fixed TestRecoveryHook

17d8fdb

zelig reviewed Apr 29, 2020

View reviewed changes

santicomp2014 added 2 commits April 29, 2020 19:27

prod, storage: first iteration of TestSenderCall and added recoveryCa…

02a6e8c

…llback in netstore, will need iteration

storage/localstore,pss/trojan,chunk,swarm: merged global pinning

2f3a515

santicomp2014 marked this pull request as ready for review April 30, 2020 17:20

santicomp2014 requested review from zelig and mortelli April 30, 2020 17:20

zelig approved these changes May 1, 2020

View reviewed changes

mortelli suggested changes May 4, 2020

View reviewed changes

mortelli added ready for review and removed in progress labels May 4, 2020

chunk,prod,pss,pss/testing,storage: removed and refactored comments i…

48ef66a

…n prod tests, refactored methods common methods in pss/prod testing, added comments for deliver and recover callbacks in respective fields

santicomp2014 commented May 4, 2020

View reviewed changes

mortelli reviewed May 4, 2020

View reviewed changes

prod/prod_test.go Outdated Show resolved Hide resolved

prod/prod_test.go Outdated Show resolved Hide resolved

mortelli approved these changes May 4, 2020

View reviewed changes

prod: changed comment testHandler to testHook

d70160c

santicomp2014 merged commit cef5587 into global-pinning May 4, 2020

mortelli deleted the global-pinning-trigger-trojanchunk branch May 4, 2020 19:10

mortelli changed the title ~~trigger trojan chunk sending~~ chunk, prod, pss, storage, swarm: trigger trojan chunk sending Jun 12, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chunk, prod, pss, storage, swarm: trigger trojan chunk sending #2166

chunk, prod, pss, storage, swarm: trigger trojan chunk sending #2166

santicomp2014 commented Apr 24, 2020 •

edited by mortelli

Loading

zelig Apr 29, 2020

santicomp2014 Apr 30, 2020

zelig left a comment

mortelli left a comment

santicomp2014 left a comment

mortelli left a comment

chunk, prod, pss, storage, swarm: trigger trojan chunk sending #2166

chunk, prod, pss, storage, swarm: trigger trojan chunk sending #2166

Conversation

santicomp2014 commented Apr 24, 2020 • edited by mortelli Loading

zelig Apr 29, 2020

Choose a reason for hiding this comment

santicomp2014 Apr 30, 2020

Choose a reason for hiding this comment

zelig left a comment

Choose a reason for hiding this comment

mortelli left a comment

Choose a reason for hiding this comment

santicomp2014 left a comment

Choose a reason for hiding this comment

mortelli left a comment

Choose a reason for hiding this comment

santicomp2014 commented Apr 24, 2020 •

edited by mortelli

Loading