Add minimum idleTimeBetweenReadsInMillis to multilang

amazon-kinesis-client-multilang/src/main/java/software/amazon/kinesis/coordinator/KinesisClientLibConfiguration.java

@@ -70,6 +70,12 @@ public class KinesisClientLibConfiguration {
      */
     public static final long DEFAULT_IDLETIME_BETWEEN_READS_MILLIS = 1000L;
 
+    /**
+     * The minimum time {@link ShardConsumer} should sleep between calls to
+     * {@link com.amazonaws.services.kinesis.AmazonKinesis#getRecords(com.amazonaws.services.kinesis.model.GetRecordsRequest)}.
+     */
+    public static final long MIN_IDLE_MILLIS_BETWEEN_READS = 200L;
+
     /**
      * Don't call processRecords() on the record processor for empty record lists.
      */
@@ -1098,6 +1104,7 @@ public KinesisClientLibConfiguration withMaxRecords(int maxRecords) {
      */
     public KinesisClientLibConfiguration withIdleTimeBetweenReadsInMillis(long idleTimeBetweenReadsInMillis) {
         checkIsValuePositive("IdleTimeBetweenReadsInMillis", idleTimeBetweenReadsInMillis);
+        idleTimeBetweenReadsInMillis = Math.max(idleTimeBetweenReadsInMillis, MIN_IDLE_MILLIS_BETWEEN_READS);
         this.idleTimeBetweenReadsInMillis = idleTimeBetweenReadsInMillis;
         return this;
     }

amazon-kinesis-client-multilang/src/test/resources/multilang.properties

@@ -58,6 +58,7 @@ shardSyncIntervalMillis = 60000
 maxRecords = 10000
 
 # Idle time between record reads in milliseconds.
+# Setting this property lower than 200ms will be overwritten to 200ms.
 idleTimeBetweenReadsInMillis = 1000
 
 # Enables applications flush/checkpoint (if they have some data "in progress", but don't get new data for while)

amazon-kinesis-client/src/main/java/software/amazon/kinesis/retrieval/polling/PollingConfig.java

@@ -26,6 +26,7 @@
 import lombok.Setter;
 import lombok.ToString;
 import lombok.experimental.Accessors;
+import lombok.extern.slf4j.Slf4j;
 import software.amazon.awssdk.services.kinesis.KinesisAsyncClient;
 import software.amazon.awssdk.services.kinesis.model.GetRecordsRequest;
 import software.amazon.kinesis.retrieval.DataFetcherProviderConfig;
@@ -38,12 +39,15 @@
 @Setter
 @ToString
 @EqualsAndHashCode
+@Slf4j
 public class PollingConfig implements RetrievalSpecificConfig {
 
     public static final Duration DEFAULT_REQUEST_TIMEOUT = Duration.ofSeconds(30);
 
     public static final int DEFAULT_MAX_RECORDS = 10000;
 
+    public static final long MIN_IDLE_MILLIS_BETWEEN_READS = 200L;
+
     /**
      * Configurable functional interface to override the existing DataFetcher.
      */
@@ -138,9 +142,14 @@ public void setIdleTimeBetweenReadsInMillis(long idleTimeBetweenReadsInMillis) {
     /**
      * Set the value for how long the ShardConsumer should sleep in between calls to
      * {@link KinesisAsyncClient#getRecords(GetRecordsRequest)}. If this is not specified here the value provided in
-     * {@link RecordsFetcherFactory} will be used.
+     * {@link RecordsFetcherFactory} will be used. Cannot set value below MIN_IDLE_MILLIS_BETWEEN_READS
      */
     public PollingConfig idleTimeBetweenReadsInMillis(long idleTimeBetweenReadsInMillis) {
+        if (idleTimeBetweenReadsInMillis < MIN_IDLE_MILLIS_BETWEEN_READS) {
+            log.warn("idleTimeBetweenReadsInMillis config property is set below the minimum allowed value of 200ms."
+                    + " This value will be automatically adjusted to 200ms.");
+            idleTimeBetweenReadsInMillis = MIN_IDLE_MILLIS_BETWEEN_READS;
+        }
         usePollingConfigIdleTimeValue = true;
         this.idleTimeBetweenReadsInMillis = idleTimeBetweenReadsInMillis;
         return this;

amazon-kinesis-client/src/test/java/software/amazon/kinesis/retrieval/polling/PollingConfigTest.java

@@ -48,4 +48,10 @@ public void testInvalidStateMultiWithStreamName() {
     public void testInvalidRecordLimit() {
         config.maxRecords(PollingConfig.DEFAULT_MAX_RECORDS + 1);
     }
+
+    @Test
+    public void testMinIdleMillisLimit() {
+        config.idleTimeBetweenReadsInMillis(0);
+        assertEquals(config.idleTimeBetweenReadsInMillis(), PollingConfig.MIN_IDLE_MILLIS_BETWEEN_READS);
+    }
 }