Skip to content

Commit

Permalink
fix: wrong builder metrics flag (#319)
Browse files Browse the repository at this point in the history
Fixes:
* Change Mev boost Builder metrics flags. Using `--metrics.builder=true`
cause this flag to be considered as `false` and making builder metrics
to not being recorded.
* Fix early return on
https://github.com/kurtosis-tech/ethereum-package/blob/main/main.star#L236-L242
causing the execution to finish before adding the additional services.

---------

Co-authored-by: Gyanendra Mishra <anomaly.the@gmail.com>
  • Loading branch information
cbermudez97 and h4ck3rk3y authored Oct 19, 2023
1 parent 946fbf0 commit 51a4422
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions main.star
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@ def run(plan, args={}):
)
all_mevboost_contexts.append(mev_boost_context)

if len(args_with_right_defaults.additional_services) == 0:
output = struct(
all_participants=all_participants,
final_genesis_timestamp=final_genesis_timestamp,
Expand Down
2 changes: 1 addition & 1 deletion src/package_io/input_parser.star
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,7 @@ def enrich_mev_extra_params(parsed_arguments_dict, mev_prefix, mev_port, mev_typ
),
'--miner.extradata="Illuminate Dmocratize Dstribute"',
"--builder.algotype=greedy",
"--metrics.builder=true",
"--metrics.builder",
]
+ parsed_arguments_dict["mev_params"]["mev_builder_extra_args"],
"el_extra_env_vars": {
Expand Down

0 comments on commit 51a4422

Please sign in to comment.