parameterize mev-boost args

ethpandaops · Dec 10, 2023 · aac0bf3 · aac0bf3
1 parent 3c06194
commit aac0bf3
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 14 deletions.
diff --git a/main.star b/main.star
@@ -241,9 +241,7 @@ def run(plan, args={}):
     if mev_endpoints:
         for index, participant in enumerate(all_participants):
             if args_with_right_defaults.participants[index].validator_count != 0:
-                mev_boost_launcher = mev_boost.new_mev_boost_launcher(
-                    MEV_BOOST_SHOULD_CHECK_RELAY, mev_endpoints
-                )
+                mev_boost_launcher = mev_boost.new_mev_boost_launcher(mev_endpoints)
                 mev_boost_service_name = "{0}{1}".format(
                     input_parser.MEV_BOOST_SERVICE_NAME_PREFIX, index
                 )
@@ -253,6 +251,7 @@ def run(plan, args={}):
                     mev_boost_service_name,
                     network_params.network_id,
                     mev_params.mev_boost_image,
+                    mev_params.mev_boost_extra_args,
                 )
                 all_mevboost_contexts.append(mev_boost_context)
 

diff --git a/network_params.yaml b/network_params.yaml
@@ -71,4 +71,6 @@ mev_params:
   mev_flood_image: flashbots/mev-flood
   mev_flood_extra_args: []
   mev_flood_seconds_per_bundle: 15
+  mev_boost_image: flashbots/mev-boost
+  mev_boost_extra_args: []
 grafana_additional_dashboards: []
diff --git a/src/mev_boost/mev_boost_launcher.star b/src/mev_boost/mev_boost_launcher.star
@@ -17,8 +17,10 @@ NETWORK_ID_TO_NAME = {
 }
 
 
-def launch(plan, mev_boost_launcher, service_name, network_id, mev_boost_image):
-    config = get_config(mev_boost_launcher, network_id, mev_boost_image)
+def launch(
+    plan, mev_boost_launcher, service_name, network_id, mev_boost_image, mev_boost_args
+):
+    config = get_config(mev_boost_launcher, network_id, mev_boost_image, mev_boost_args)
 
     mev_boost_service = plan.add_service(service_name, config)
 
@@ -27,11 +29,8 @@ def launch(plan, mev_boost_launcher, service_name, network_id, mev_boost_image):
     )
 
 
-def get_config(mev_boost_launcher, network_id, mev_boost_image):
-    command = ["mev-boost"]
-
-    if mev_boost_launcher.should_check_relay:
-        command.append("-relay-check")
+def get_config(mev_boost_launcher, network_id, mev_boost_image, mev_boost_args):
+    command = mev_boost_args
 
     return ServiceConfig(
         image=mev_boost_image,
@@ -53,7 +52,5 @@ def get_config(mev_boost_launcher, network_id, mev_boost_image):
     )
 
 
-def new_mev_boost_launcher(should_check_relay, relay_end_points):
-    return struct(
-        should_check_relay=should_check_relay, relay_end_points=relay_end_points
-    )
+def new_mev_boost_launcher(relay_end_points):
+    return struct(relay_end_points=relay_end_points)
diff --git a/src/package_io/input_parser.star b/src/package_io/input_parser.star
@@ -179,6 +179,7 @@ def input_parser(plan, input_args):
             mev_builder_image=result["mev_params"]["mev_builder_image"],
             mev_builder_cl_image=result["mev_params"]["mev_builder_cl_image"],
             mev_boost_image=result["mev_params"]["mev_boost_image"],
+            mev_boost_extra_args=result["mev_params"]["mev_boost_extra_args"],
             mev_relay_api_extra_args=result["mev_params"]["mev_relay_api_extra_args"],
             mev_relay_housekeeper_extra_args=result["mev_params"][
                 "mev_relay_housekeeper_extra_args"
@@ -442,6 +443,7 @@ def get_default_mev_params():
         "mev_builder_image": "flashbots/builder:latest",
         "mev_builder_cl_image": "sigp/lighthouse:latest",
         "mev_boost_image": "flashbots/mev-boost",
+        "mev_boost_extra_args": ["mev-boost", "--relay-check"],
         "mev_relay_api_extra_args": [],
         "mev_relay_housekeeper_extra_args": [],
         "mev_relay_website_extra_args": [],