Skip to content

Commit

Permalink
fix: remove un-needed prysm vc check (#542)
Browse files Browse the repository at this point in the history
  • Loading branch information
barnabasbusa authored Apr 5, 2024
1 parent a1ae708 commit f6326fe
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 12 deletions.
10 changes: 5 additions & 5 deletions src/vc/prysm.star
Original file line number Diff line number Diff line change
Expand Up @@ -36,16 +36,11 @@ def get_config(
prysm_password_relative_filepath,
)

if cl_context.client_name != constants.CL_TYPE.prysm:
beacon_grpc_url = beacon_http_url[7:] # remove the "http://" prefix

cmd = [
"--accept-terms-of-use=true", # it's mandatory in order to run the node
"--chain-config-file="
+ constants.GENESIS_CONFIG_MOUNT_PATH_ON_CONTAINER
+ "/config.yaml",
"--beacon-rpc-provider=" + cl_context.beacon_grpc_url,
"--beacon-rest-api-provider=" + cl_context.beacon_grpc_url,
"--wallet-dir=" + validator_keys_dirpath,
"--wallet-password-file=" + validator_secrets_dirpath,
"--suggested-fee-recipient=" + constants.VALIDATING_REWARDS_ACCOUNT,
Expand All @@ -70,7 +65,12 @@ def get_config(
]

if cl_context.client_name != constants.CL_TYPE.prysm:
cmd.append("--beacon-rpc-provider=" + beacon_http_url)
cmd.append("--beacon-rest-api-provider=" + beacon_http_url)
cmd.append("--enable-beacon-rest-api")
else: # we are using Prysm CL
cmd.append("--beacon-rpc-provider=" + cl_context.beacon_grpc_url)
cmd.append("--beacon-rest-api-provider=" + cl_context.beacon_grpc_url)

if len(extra_params) > 0:
# this is a repeated<proto type>, we convert it into Starlark
Expand Down
7 changes: 0 additions & 7 deletions src/vc/vc_launcher.star
Original file line number Diff line number Diff line change
Expand Up @@ -161,13 +161,6 @@ def launch(
keymanager_enabled=keymanager_enabled,
)
elif vc_type == constants.VC_TYPE.prysm:
# Prysm VC only works with Prysm beacon node right now
if cl_context.client_name != constants.CL_TYPE.prysm:
fail(
cl_context.client_name
+ "Prysm VC is only compatible with Prysm beacon node"
)

config = prysm.get_config(
el_cl_genesis_data=launcher.el_cl_genesis_data,
image=image,
Expand Down

0 comments on commit f6326fe

Please sign in to comment.