Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(prysm): run p2p-udp on different port as it might conflict with the new quic port #845

Merged
merged 1 commit into from
Dec 4, 2024
Merged

fix(prysm): run p2p-udp on different port as it might conflict with the new quic port #845

merged 1 commit into from
Dec 4, 2024

Conversation

skylenet
Copy link
Member

@skylenet skylenet commented Dec 4, 2024 •
edited
Loading

Prysm added QUIC to their client as per prysmaticlabs/prysm#14688 . This currently broke our runs using the master branch prysm image due to the QUIC port running on 13000 by default. Which was conflicting with the settings we were providing for the UDP port:

--p2p-quic-port value                                The QUIC port used by libp2p. (default: 13000)
--p2p-tcp-port value                                 The TCP port used by libp2p. (default: 13000)
--p2p-udp-port value                                 The UDP port used by the discovery service discv5. (default: 12000)

I've also added the CLI flags for it, but still commented out until a stable release is done.

@skylenet skylenet changed the title fix(prysm): run p2p-udp on different port as it might conflict with t… fix(prysm): run p2p-udp on different port as it might conflict with the new quick port Dec 4, 2024
@skylenet skylenet changed the title fix(prysm): run p2p-udp on different port as it might conflict with the new quick port fix(prysm): run p2p-udp on different port as it might conflict with the new quic port Dec 4, 2024
@skylenet skylenet merged commit 3bb88e0 into main Dec 4, 2024
15 of 16 checks passed
@skylenet skylenet deleted the skylenet/fix-prysm-port-conflict branch December 4, 2024 09:45
@EthPandaOpsBot EthPandaOpsBot mentioned this pull request Dec 3, 2024
Closed
This was referenced Feb 10, 2025
Closed
Merged
skylenet pushed a commit that referenced this pull request Feb 10, 2025
@EthPandaOpsBot
chore(main): release 4.5.0 (#897)
e957062 
🤖 I have created a release *beep* *boop*
---


##
[4.5.0](4.4.0...4.5.0)
(2025-02-10)


### ⚠ BREAKING CHANGES

* remove vc_count
([#844](#844))

### Features

* add custom image for egg
([#859](#859))
([e60afbe](e60afbe))
* add gossip limit as a configuratable flag
([#856](#856))
([56a3197](56a3197))
* add max,target blobs for future forks
([#851](#851))
([1c33375](1c33375))
* add op package per pr check
([#854](#854))
([0e4e7aa](0e4e7aa))
* add spamoor
([#850](#850))
([a01d772](a01d772))
* add support for pull through cache
([#833](#833))
([0b2a2ae](0b2a2ae))
* add vero `vc_type`
([#827](#827))
([c2af143](c2af143))
* Add-blockscout_params
([#838](#838))
([777ec06](777ec06))
* Adding support for EIP-7732 and EIP-7805
([#880](#880))
([6b7a409](6b7a409))
* Adding support for new system contracts + updating devnet config
([#862](#862))
([8ed275a](8ed275a))
* Replacing mock builder
([#864](#864))
([d3a0024](d3a0024))
* support older forks
([#846](#846))
([d7e31e0](d7e31e0))
* update blockscout with new frontend
([#843](#843))
([4f69962](4f69962))
* Update devnet-5 example
([#863](#863))
([04e13f3](04e13f3))
* Update egg to support new system contract addresses
([#883](#883))
([9f7ad78](9f7ad78))
* use `eip7732-support` image for dora when eip7732 is scheduled for
activation (ePBS)
([#881](#881))
([dbe7912](dbe7912))


### Bug Fixes

* add fulu overrides automatically for assertoor and dora if fulu is
active
([#858](#858))
([d6bec16](d6bec16))
* add txpool to reth api
([#841](#841))
([35ec958](35ec958))
* bump assertoor memory limit to 8G
([#874](#874))
([8ff3b11](8ff3b11))
* comment out optimism check from per-PR workflow
([#878](#878))
([02323a3](02323a3))
* dora override
([#857](#857))
([50ec581](50ec581))
* Enable txpool on geth,besu and nethermind
([#868](#868))
([f9d0b50](f9d0b50))
* Fixes minimal runs with deneb state
([#871](#871))
([2ca35e8](2ca35e8))
* mev-builder custom image
([#847](#847))
([bc89ad3](bc89ad3))
* Private key for account 20
([#870](#870))
([9782552](9782552))
* **prysm:** run p2p-udp on different port as it might conflict with the
new quic port
([#845](#845))
([3bb88e0](3bb88e0))
* rbuilder upstream repo with reth-rbuilder binary
([#828](#828))
([55df658](55df658))
* remove vc_count
([#844](#844))
([b61a128](b61a128))
* replace goomy with spamoor
([#860](#860))
([28f7b7d](28f7b7d))
* revert egg version
([#852](#852))
([a182f30](a182f30))
* sanity check for count
([#835](#835))
([2633d15](2633d15))
* Update default mev-images source
([#884](#884))
([176b08a](176b08a))
* Update Erigon docker image repo naming
([#834](#834))
([ceb1444](ceb1444))
* Update ethereum-genesis-generator to fix eip7623 timestamp missing for
Nethermind
([#875](#875))
([1c1d698](1c1d698))
* update kt config
([#876](#876))
([1704194](1704194))
* Update rbuilder flag and add mainnet split example
([#885](#885))
([4bbd070](4bbd070))
* Update test files
([#893](#893))
([4fcca66](4fcca66))
* use default image for assertoor with electra enabled
([#855](#855))
([3b51e5e](3b51e5e))
* use writable path for assertoor db
([#877](#877))
([a913455](a913455))


### Miscellaneous Chores

* release 4.5.0
([#896](#896))
([0dc54e0](0dc54e0))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parithosh parithosh parithosh approved these changes

@barnabasbusa barnabasbusa Awaiting requested review from barnabasbusa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skylenet @parithosh