Skip to content

Commit

Permalink
fix: image label name too long, truncate at 63 chars (#90)
Browse files Browse the repository at this point in the history
  • Loading branch information
barnabasbusa authored Nov 21, 2024
1 parent 5b085c8 commit 5bd687c
Show file tree
Hide file tree
Showing 8 changed files with 9 additions and 7 deletions.
2 changes: 1 addition & 1 deletion src/cl/hildr/hildr_launcher.star
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ def get_beacon_config(
"labels": ethereum_package_shared_utils.label_maker(
client=constants.CL_TYPE.op_node,
client_type=constants.CLIENT_TYPES.cl,
image=participant.cl_image,
image=participant.cl_image[: constants.MAX_LABEL_LENGTH],
connected_client=el_context.client_name,
extra_labels=participant.cl_extra_labels,
),
Expand Down
2 changes: 1 addition & 1 deletion src/cl/op-node/op_node_launcher.star
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ def get_beacon_config(
"labels": ethereum_package_shared_utils.label_maker(
client=constants.CL_TYPE.op_node,
client_type=constants.CLIENT_TYPES.cl,
image=participant.cl_image,
image=participant.cl_image[: constants.MAX_LABEL_LENGTH],
connected_client=el_context.client_name,
extra_labels=participant.cl_extra_labels,
),
Expand Down
2 changes: 1 addition & 1 deletion src/el/op-besu/op_besu_launcher.star
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ def get_config(
"labels": ethereum_package_shared_utils.label_maker(
client=constants.EL_TYPE.op_besu,
client_type=constants.CLIENT_TYPES.el,
image=participant.el_image,
image=participant.el_image[: constants.MAX_LABEL_LENGTH],
connected_client=cl_client_name,
extra_labels=participant.el_extra_labels,
),
Expand Down
2 changes: 1 addition & 1 deletion src/el/op-erigon/op_erigon_launcher.star
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ def get_config(
"labels": ethereum_package_shared_utils.label_maker(
client=constants.EL_TYPE.op_erigon,
client_type=constants.CLIENT_TYPES.el,
image=participant.el_image,
image=participant.el_image[: constants.MAX_LABEL_LENGTH],
connected_client=cl_client_name,
extra_labels=participant.el_extra_labels,
),
Expand Down
2 changes: 1 addition & 1 deletion src/el/op-geth/op_geth_launcher.star
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ def get_config(
"labels": ethereum_package_shared_utils.label_maker(
client=constants.EL_TYPE.op_geth,
client_type=constants.CLIENT_TYPES.el,
image=participant.el_image,
image=participant.el_image[: constants.MAX_LABEL_LENGTH],
connected_client=cl_client_name,
extra_labels=participant.el_extra_labels,
),
Expand Down
2 changes: 1 addition & 1 deletion src/el/op-nethermind/op_nethermind_launcher.star
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ def get_config(
"labels": ethereum_package_shared_utils.label_maker(
client=constants.EL_TYPE.op_nethermind,
client_type=constants.CLIENT_TYPES.el,
image=participant.el_image,
image=participant.el_image[: constants.MAX_LABEL_LENGTH],
connected_client=cl_client_name,
extra_labels=participant.el_extra_labels,
),
Expand Down
2 changes: 1 addition & 1 deletion src/el/op-reth/op_reth_launcher.star
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ def get_config(
"labels": ethereum_package_shared_utils.label_maker(
client=constants.EL_TYPE.op_reth,
client_type=constants.CLIENT_TYPES.el,
image=participant.el_image,
image=participant.el_image[: constants.MAX_LABEL_LENGTH],
connected_client=cl_client_name,
extra_labels=participant.el_extra_labels,
),
Expand Down
2 changes: 2 additions & 0 deletions src/package_io/constants.star
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,5 @@ VOLUME_SIZE = {
"hildr_volume_size": 1000, # 1GB
},
}

MAX_LABEL_LENGTH = 63

0 comments on commit 5bd687c

Please sign in to comment.